feat: enable swift/packageresolved plugin to detect SwiftURL vulnerabilities#2801
Open
herdiyana256 wants to merge 4 commits into
Open
feat: enable swift/packageresolved plugin to detect SwiftURL vulnerabilities#2801herdiyana256 wants to merge 4 commits into
herdiyana256 wants to merge 4 commits into
Conversation
Collaborator
|
Can you try rebasing on the new go.mod. Hopefully that'll fix the CI issues. |
herdiyana256
force-pushed
the
feature/enable-swift-packageresolved-plugin
branch
from
cd2246f to
5d6a50b
Compare
Author
|
Hi @another-rex, done! Branch has been rebased onto the latest go.mod from upstream main (5a15332). Ready for CI approval. Thank you! |
Collaborator
|
Thanks for resolving the unrelated issue with the govulncheck update. I might pull that into a separate PR just to keep the commits clean. |
Enable the swift/packageresolved extractor plugin in the default lockfile preset so that Package.resolved files are automatically scanned for SwiftURL ecosystem vulnerabilities. Add E2E test cases demonstrating successful detection of: - GHSA-84m3-f99p-cqx5 (github.com/pytorch/executorch 0.6.0, Critical 9.8) - GHSA-xvr7-p2c6-j83w (github.com/apple/swift-nio-http2 1.19.1, Medium 6.3) - Plus 10 additional SwiftURL advisories across the 2 test fixtures Total: 12 SwiftURL vulnerabilities detected from 2 packages. Follow-up to google/osv-scalibr#2034 as requested by @another-rex. Note: After google/osv-scalibr#2034 is merged via copybara, run: go get github.com/google/osv-scalibr@latest && go mod tidy before opening this PR upstream.
…can discover packages
herdiyana256
force-pushed
the
feature/enable-swift-packageresolved-plugin
branch
from
3d13abd to
4a7d22c
Compare
Author
|
@another-rex, rebased again on latest main (b170227). Ready for CI re-approval. Thank you for your patience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to
google/osv-scalibr#2034which fixed the purl type forswift/packageresolved.This PR:
google/osv-scalibrto include the fix (commitd13148df68e0).swift/packageresolvedplugin inosv-scannerpresets.SwiftURLadvisories, includingGHSA-84m3-f99p-cqx5(executorch) andGHSA-xvr7-p2c6-j83w(swift-nio-http2).Testing:
go test ./cmd/osv-scanner/scan/source/...passes with expected E2E CVE detections.